fixes OverflowException if UnicstProcessr request and onNext race #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion` Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
|
pointers to the failed test -> https://travis-ci.org/github/rsocket/rsocket-java/jobs/759973034 with the mentioned exception in the original issue |
Signed-off-by: Oleh Dokuka <[email protected]>
rstoyanchev
requested changes
Feb 22, 2021
There was a problem hiding this comment.
Looks good as a tactical solution in 1.0.x for now, although eventually it should be replaced with the queue-free and WIP-free UnicstProcessor you mentioned in #959 (comment).
Signed-off-by: Oleh Dokuka <[email protected]>
OlegDokuka
force-pushed
the
bugfix/#959
branch
from
f8249eb to
bcab4eb
Compare
OlegDokuka
changed the title
reactor.core.Exceptions$OverflowException reactor.core.Exceptions$OverflowException in case of UnicastProcess #request races with #onNext
rstoyanchev
approved these changes
Feb 25, 2021
OlegDokuka
changed the title
reactor.core.Exceptions$OverflowException in case of UnicastProcess #request races with #onNext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #959
Some fix details:
Due to the RSocket Specification, section "Handling the unexpected"
the
RequestOperatordoes unbounded request to theUnicastProcessoronce in order to avoid any concurrency on the internal WIP field.Signed-off-by: Oleh Dokuka [email protected]